KEMBAR78
gh-138253: Fix compatibility of sub-interpreters queues with queue.Queue by serhiy-storchaka · Pull Request #138256 · python/cpython · GitHub
Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 30, 2025

Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface.

…eue.Queue

Add the block parameter in the put() and get() methods of
the concurrent.interpreters queues for compatibility with the
queue.Queue interface.
…Ehj-N.rst

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks like a good solution, fortunatelly we discovered it before 3.14.0 :)

@gpshead
Copy link
Member

gpshead commented Aug 31, 2025

Up to @hugovk to decide if this is worthy of being in a rc. This is a bugfix on an obvious omission within a brand new public API, it'd also make sense for 3.14.1 as well given the 3.14.0rc2 docs already documented that the block parameter - https://docs.python.org/3.14/library/queue.html#queue.Queue.get

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.13 bugs and security fixes label Sep 2, 2025
@serhiy-storchaka serhiy-storchaka merged commit cb18269 into python:main Sep 2, 2025
51 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
…eue.Queue (pythonGH-138256)

Add the block parameter in the put() and get() methods of
the concurrent.interpreters queues for compatibility with the
queue.Queue interface.
(cherry picked from commit cb18269)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka deleted the interpreters-queue-block branch September 2, 2025 05:59
@bedevere-app
Copy link

bedevere-app bot commented Sep 2, 2025

GH-138367 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
hugovk pushed a commit that referenced this pull request Sep 8, 2025
…ueue.Queue (GH-138256) (#138367)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…with queue.Queue (pythonGH-138256) (python#138367)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
…eue.Queue (pythonGH-138256)

Add the block parameter in the put() and get() methods of
the concurrent.interpreters queues for compatibility with the
queue.Queue interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants