-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-138253: Fix compatibility of sub-interpreters queues with queue.Queue #138256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-138253: Fix compatibility of sub-interpreters queues with queue.Queue #138256
Conversation
…eue.Queue Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface.
Misc/NEWS.d/next/Library/2025-08-30-10-58-15.gh-issue-138253.9Ehj-N.rst
Outdated
Show resolved
Hide resolved
…Ehj-N.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! this looks like a good solution, fortunatelly we discovered it before 3.14.0 :)
|
Up to @hugovk to decide if this is worthy of being in a rc. This is a bugfix on an obvious omission within a brand new public API, it'd also make sense for 3.14.1 as well given the 3.14.0rc2 docs already documented that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…eue.Queue (pythonGH-138256) Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface. (cherry picked from commit cb18269) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-138367 is a backport of this pull request to the 3.14 branch. |
…with queue.Queue (pythonGH-138256) (python#138367) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…eue.Queue (pythonGH-138256) Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface.
Add the block parameter in the put() and get() methods of the concurrent.interpreters queues for compatibility with the queue.Queue interface.