gh-138993: Dedent `credits` text #138994

StanFromIreland · 2025-09-16T15:45:29Z

Issue: credits is indented #138993

vstinner

LGTM

miss-islington-app · 2025-10-14T08:16:02Z

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2025-10-14T08:16:02Z

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

(cherry picked from commit 207f977) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app · 2025-10-14T08:16:15Z

GH-140087 is a backport of this pull request to the 3.13 branch.

bedevere-app · 2025-10-14T08:16:22Z

GH-140088 is a backport of this pull request to the 3.14 branch.

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-bot · 2025-10-15T12:41:40Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian Linux Asan 3.14 (no tier) has failed when building commit 9e235ff.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1816/builds/78) and take a look at the build logs.
Check if the failure is related to this commit (9e235ff) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1816/builds/78

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 15, done.        
remote: Counting objects:  10% (1/10)        
remote: Counting objects:  20% (2/10)        
remote: Counting objects:  30% (3/10)        
remote: Counting objects:  40% (4/10)        
remote: Counting objects:  50% (5/10)        
remote: Counting objects:  60% (6/10)        
remote: Counting objects:  70% (7/10)        
remote: Counting objects:  80% (8/10)        
remote: Counting objects:  90% (9/10)        
remote: Counting objects: 100% (10/10)        
remote: Counting objects: 100% (10/10), done.        
remote: Compressing objects:  20% (1/5)        
remote: Compressing objects:  40% (2/5)        
remote: Compressing objects:  60% (3/5)        
remote: Compressing objects:  80% (4/5)        
remote: Compressing objects: 100% (5/5)        
remote: Compressing objects: 100% (5/5), done.        
remote: Total 15 (delta 5), reused 5 (delta 5), pack-reused 5 (from 2)        
From https://github.com/python/cpython
 * branch                    3.14       -> FETCH_HEAD
Note: switching to '9e235ffb215fcf31f8792a37e8a935741e8d3097'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 9e235ffb215 [3.14] gh-138993: Dedent `credits` text (GH-138994) (#140088)
Switched to and reset branch '3.14'

configure: WARNING: no system libmpdec found; falling back to bundled libmpdec (deprecated and scheduled for removal in Python 3.16)

In file included from ./Include/internal/pycore_dict.h:11,
                 from Objects/typeobject.c:7:
In function ‘Py_DECREF_MORTAL’,
    inlined from ‘PyStackRef_XCLOSE’ at ./Include/internal/pycore_stackref.h:660:9,
    inlined from ‘_PyThreadState_PopCStackRef’ at ./Include/internal/pycore_stackref.h:746:5,
    inlined from ‘vectorcall_maybe’ at Objects/typeobject.c:2984:9:
./Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’ {aka ‘struct _object[]’} [-Warray-bounds]
  481 |     if (--op->ob_refcnt == 0) {
      |        ^

Timeout (0:05:00)!
Thread 0x0000007faefef100 [Thread-2] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2043 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1082 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1044 in _bootstrap

Thread 0x0000007faf7ff100 [Thread-1] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 2058 in _wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/subprocess.py", line 1278 in wait
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 194 in _run_process
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 299 in run_tmp_files
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 363 in _runtest
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 403 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1082 in _bootstrap_inner
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/threading.py", line 1044 in _bootstrap

Thread 0x0000007fbb5316c0 [python] (most recent call first):
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 536 in _get_result
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/run_workers.py", line 610 in run
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 455 in _run_tests_mp
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 561 in _run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 598 in run_tests
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 779 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/libregrtest/main.py", line 787 in main
  File "/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/Lib/test/__main__.py", line 2 in <module>
  File "<frozen runpy>", line 88 in _run_code
  File "<frozen runpy>", line 198 in _run_module_as_main
make: *** [Makefile:2496: buildbottest] Error 1

Cannot open file '/home/buildbot/buildarea/3.14.pablogsal-rasp.asan/build/test-results.xml' for upload

Commit

6ceca50

StanFromIreland requested a review from FFY00 as a code owner September 16, 2025 15:45

bedevere-app bot added the awaiting review label Sep 16, 2025

StanFromIreland added skip news and removed awaiting review labels Sep 16, 2025

bedevere-app bot mentioned this pull request Sep 16, 2025

credits is indented #138993

Closed

StanFromIreland added awaiting review and removed skip news labels Sep 16, 2025

Blurbed

84a7d94

aisk approved these changes Sep 17, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Sep 17, 2025

vstinner approved these changes Sep 18, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels Sep 18, 2025

hugovk merged commit 207f977 into python:main Oct 14, 2025
53 checks passed

bedevere-app bot removed the awaiting merge label Oct 14, 2025

hugovk added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 14, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025

pythongh-138993: Dedent credits text (pythonGH-138994)

2c92fa0

(cherry picked from commit 207f977) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2025

pythongh-138993: Dedent credits text (pythonGH-138994)

9e7f630

(cherry picked from commit 207f977) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 14, 2025

StanFromIreland deleted the credits-dedent branch October 14, 2025 12:39

hugovk pushed a commit that referenced this pull request Oct 15, 2025

[3.14] gh-138993: Dedent credits text (GH-138994) (#140088)

9e235ff

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

hugovk pushed a commit that referenced this pull request Oct 15, 2025

[3.13] gh-138993: Dedent credits text (GH-138994) (#140087)

7797676

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-138993: Dedent `credits` text #138994

gh-138993: Dedent `credits` text #138994

Uh oh!

StanFromIreland commented Sep 16, 2025 •

edited by bedevere-app bot

Loading

Uh oh!

vstinner left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Oct 14, 2025

Uh oh!

miss-islington-app bot commented Oct 14, 2025

Uh oh!

bedevere-app bot commented Oct 14, 2025

Uh oh!

bedevere-app bot commented Oct 14, 2025

Uh oh!

bedevere-bot commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

gh-138993: Dedent credits text #138994

gh-138993: Dedent credits text #138994

Uh oh!

Conversation

StanFromIreland commented Sep 16, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Oct 14, 2025

Uh oh!

miss-islington-app bot commented Oct 14, 2025

Uh oh!

bedevere-app bot commented Oct 14, 2025

Uh oh!

bedevere-app bot commented Oct 14, 2025

Uh oh!

bedevere-bot commented Oct 15, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gh-138993: Dedent `credits` text #138994

gh-138993: Dedent `credits` text #138994

StanFromIreland commented Sep 16, 2025 •

edited by bedevere-app bot

Loading