KEMBAR78
gh-135729: Store reference to globals in `Interpreter._decref` by ZeroIntensity · Pull Request #139104 · python/cpython · GitHub
Skip to content

gh-135729: Store reference to globals in Interpreter._decref #139104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2025
Merged

gh-135729: Store reference to globals in Interpreter._decref #139104

merged 4 commits into from
Sep 18, 2025

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Sep 18, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 18, 2025
Closed
ericsnowcurrently
ericsnowcurrently approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor formatting recommendation, LGTM.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Sprint 2024 Sep 18, 2025
@ZeroIntensity @ericsnowcurrently
Update __init__.py
ac3292f 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ZeroIntensity ZeroIntensity enabled auto-merge (squash) September 18, 2025 10:57
@ZeroIntensity ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
@ZeroIntensity ZeroIntensity merged commit 571210b into python:main Sep 18, 2025
47 checks passed
@ZeroIntensity ZeroIntensity deleted the fix-interp-del branch September 18, 2025 11:17
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sprint 2024 Sep 18, 2025
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
@ZeroIntensity @miss-islington
pythongh-135729: Store reference to globals in Interpreter._decref (p…
3476f45 
…ythonGH-139104)

(cherry picked from commit 571210b)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2025

GH-139112 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
ZeroIntensity added a commit that referenced this pull request Oct 7, 2025
@miss-islington @ZeroIntensity
[3.14] gh-135729: Store reference to globals in Interpreter._decref (…
070993b 
…GH-139104) (GH-139112)

* gh-135729: Store reference to globals in `Interpreter._decref` (GH-139104)
(cherry picked from commit 571210b)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

sprint

Projects

Sprint 2024
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @ericsnowcurrently