gh-139640: Fix swallowing syntax warnings in different modules (restore duplicated PEP 765 warnings) #139755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
ambv,
iritkatriel,
lysnikolaou,
markshannon and
pablogsal
as code owners
|
This is a third alternative -- just restore the double PEP 765 warnings. Temporary, I hope. |
serhiy-storchaka
changed the title
Revert pythonGH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line.
serhiy-storchaka
force-pushed
the
compile-syntax-warnings3
branch
from
6cb99f0 to
c12e7ec
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 14, 2025
…ythonGH-139755) Revert pythonGH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line. (cherry picked from commit 279db6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-140117 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 14, 2025
…odules (pythonGH-139755) Revert pythonGH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line. (cherry picked from commit 279db6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-140119 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 14, 2025
…odules (pythonGH-139755) Revert pythonGH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line. Fix duplicated warnings in the "finally" block. (cherry picked from commit 279db6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 14, 2025
…GH-139755) (GH-140119) Revert GH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line. Fix duplicated warnings in the "finally" block. (cherry picked from commit 279db6b)
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 14, 2025
…GH-139755) (GH-140117) Revert GH-131993. Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line. Fix duplicated warnings in the "finally" block. (cherry picked from commit 279db6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> * Update 2025-10-06-10-03-37.gh-issue-139640.gY5oTb.rst --------- Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert GH-131993.
Fix swallowing some syntax warnings in different modules if they accidentally have the same message and are emitted from the same line.