bpo-14935: Remove static state from the _csv module #23224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
shihai1991
reviewed
Nov 10, 2020
shihai1991
reviewed
Nov 10, 2020
vstinner
reviewed
Nov 12, 2020
vstinner
reviewed
Nov 17, 2020
vstinner
approved these changes
Dec 8, 2020
Modules/_csv.c
Outdated
|
|
||
| PyType_Spec Writer_Type_spec = { | ||
| "_csv.writer", | ||
| sizeof(WriterObj), |
There was a problem hiding this comment.
maybe use ".m_xxx = xxx" syntax here, as you did for the other spec below. Same remark for Reader_Type_spec.
shihai1991
approved these changes
Dec 8, 2020
This was referenced Dec 15, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
This was referenced May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges code/ideas from gh-20974 and gh-16078, and uses the new
_PyType_GetModuleByDef.Co-authored-by: Marcel Plch gmarcel.plch@gmail.com
Co-authored-by: Eddie Elizondo eduardo.elizondorueda@gmail.com
Co-authored-by: Hai Shi shihai1992@gmail.com
https://bugs.python.org/issue14935