KEMBAR78
gh-93626: Set the release for `__future__.annotations` to `None` by KotlinIsland · Pull Request #93628 · python/cpython · GitHub
Skip to content

gh-93626: Set the release for __future__.annotations to None #93628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2022
Merged

gh-93626: Set the release for __future__.annotations to None #93628

merged 3 commits into from
Jul 5, 2022

Conversation

@KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Jun 9, 2022 •
edited
Loading

Hi everyone, I noticed that __future__.annotations was turned on in the 3.11 betas 😳😳😳😳😳😳.

This is highly sus as it should be turned off till further notice (3.12 :trollface:) (None kinda means 'tbd' I think).

This is my first cpython contrib, I tried to follow the contributing process, but maybe I missed something, sorry!

This PR also needs to be backported to the 3.11 branch

resolves: #93626

Corresponding typeshed PR python/typeshed#8232

@ghost
Copy link

ghost commented Jun 9, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@KotlinIsland
Copy link
Contributor Author

I think your CLA facility is busted, when I sign it, it just says:

Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: kotlinisland@users.noreply.github.com.

@Fidget-Spinner Fidget-Spinner requested a review from pablogsal June 9, 2022 07:15
@KotlinIsland
Copy link
Contributor Author

@pablogsal I've changed the mandatory release to None to reflect that the release version is 'tbd'

@arhadthedev arhadthedev mentioned this pull request Jun 19, 2022
Closed
@ambv
Copy link
Contributor

ambv commented Jun 20, 2022

@KotlinIsland can you try signing the CLA again?

@KotlinIsland
Copy link
Contributor Author

KotlinIsland commented Jun 20, 2022 •
edited
Loading

@ambv

Thank you for authorizing our application, but the CLA must be signed by the users who contributed to the PR. Authors emails are: kotlinisland@users.noreply.github.com,65446343+KotlinIsland@users.noreply.github.com.

@ambv
Copy link
Contributor

ambv commented Jun 20, 2022

@KotlinIsland please try again.

@KotlinIsland KotlinIsland changed the title gh-93626: Set the release for __future__.annotations to 3.12 gh-93626: Set the release for __future__.annotations to None Jun 21, 2022
@KotlinIsland
Copy link
Contributor Author

@ambv it worked 😳.
Thanks 😁

@KotlinIsland KotlinIsland force-pushed the patch-1 branch 2 times, most recently from 1927446 to 0b37fba Compare June 21, 2022 01:39
@ambv ambv mentioned this pull request Jun 21, 2022
Merged
@KotlinIsland
Copy link
Contributor Author

@graingert This needs to be backported to 3.11

@KotlinIsland
Copy link
Contributor Author

@pablogsal This is a critical release blocker for 3.11

DetachHead
DetachHead approved these changes Jun 29, 2022
View reviewed changes
Copy link

@DetachHead DetachHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀🚀

JelleZijlstra
JelleZijlstra reviewed Jun 29, 2022
View reviewed changes
Doc/whatsnew/3.11.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this fits here as there's no change.

Copy link
Contributor Author

@KotlinIsland KotlinIsland Jun 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I rushed to the release page to see the status of pep 563 as in 3.10 it was marked as being released in 3.11. And was surprised to see that there was no mention of it, despite the fact that it has been pulled from 3.11.

I hadn't seen any of the information regarding it's changed status, it would be of value to be to have it in here. Maybe it could be moved to a different section of the release notes? or maybe the full-form changelog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps in the "Improved Modules" section it could be listed under __future__?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest something along the lines of a "Non-futures Related to Type Hints" subsection of the "New Features Related to Type Hints" section above. Maybe not that particular name, but I enjoyed coming up with it :)

Lines in our reST docs should be wrapped at 80 columns as noted in the devguide.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I used your suggested name because I didn't understand what you meant by it😁

@KotlinIsland KotlinIsland mentioned this pull request Jun 30, 2022
Closed
graingert
graingert requested changes Jun 30, 2022
View reviewed changes
zware
zware previously requested changes Jun 30, 2022
View reviewed changes
Doc/whatsnew/3.11.rst Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest something along the lines of a "Non-futures Related to Type Hints" subsection of the "New Features Related to Type Hints" section above. Maybe not that particular name, but I enjoyed coming up with it :)

Lines in our reST docs should be wrapped at 80 columns as noted in the devguide.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@KotlinIsland KotlinIsland requested a review from zware July 1, 2022 08:32
@KotlinIsland KotlinIsland mentioned this pull request Jul 3, 2022
Merged
graingert
graingert reviewed Jul 3, 2022
View reviewed changes
gvanrossum
gvanrossum reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits (tweaking the section heading, and keeping the long url on one line), otherwise LGTM.

@zware zware dismissed their stale review July 5, 2022 00:08

Changes made, chance to re-review not currently available

KotlinIsland and others added 2 commits July 5, 2022 17:36
@KotlinIsland @gvanrossum
Update whatsnew
6e0a02d 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@KotlinIsland @gvanrossum
Update whatsnew
997df43 
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
@ambv ambv added the needs backport to 3.11 only security fixes label Jul 5, 2022
@ambv ambv merged commit 4791a8a into python:main Jul 5, 2022
@miss-islington
Copy link
Contributor

Thanks @KotlinIsland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-94553 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
@KotlinIsland @miss-islington
pythongh-93626: Set the release for __future__.annotations to None (
b7ccccb 
pythonGH-93628)

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
(cherry picked from commit 4791a8a)

Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
@graingert
Copy link
Contributor

does this make sense backported to 3.10?

@ambv
Copy link
Contributor

ambv commented Jul 5, 2022

There is no 3.11 whatsnew in 3.10 and it seems to me that the clarified meaning of None shouldn't be used mid-release cycle.

ambv pushed a commit that referenced this pull request Jul 5, 2022
@miss-islington @KotlinIsland
gh-93626: Set the release for __future__.annotations to None (GH-…
99a0668 
…93628) (GH-94553)

Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
(cherry picked from commit 4791a8a)

Co-authored-by: KotlinIsland <65446343+KotlinIsland@users.noreply.github.com>
@KotlinIsland KotlinIsland deleted the patch-1 branch July 5, 2022 09:27
@KotlinIsland KotlinIsland mentioned this pull request Sep 13, 2022
Closed
@andersk andersk mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@graingert graingert graingert requested changes

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@gvanrossum gvanrossum gvanrossum left review comments

@pablogsal pablogsal Awaiting requested review from pablogsal

@zware zware Awaiting requested review from zware

+1 more reviewer

@DetachHead DetachHead DetachHead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

__future__.annotations has inaccurate mandatoryRelease value

9 participants

@KotlinIsland @ambv @bedevere-bot @miss-islington @graingert @JelleZijlstra @gvanrossum @zware @DetachHead