KEMBAR78
GH-98897: fix memory leak if `math.dist` raises exception by kumaraditya303 · Pull Request #98898 · python/cpython · GitHub
Skip to content

GH-98897: fix memory leak if math.dist raises exception #98898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 1, 2022
Merged

GH-98897: fix memory leak if math.dist raises exception #98898

merged 6 commits into from
Nov 1, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 31, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Oct 31, 2022
Closed
vstinner
vstinner reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test to make sure that we don't reintroduce this memory leak later?

@kumaraditya303
Copy link
Contributor Author

Can you please add a test to make sure that we don't reintroduce this memory leak later?

Added test.

@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 31, 2022
vstinner
vstinner reviewed Oct 31, 2022
View reviewed changes
kumaraditya303 and others added 2 commits October 31, 2022 16:01
@kumaraditya303 @vstinner
code review
4deccb3 
Co-authored-by: Victor Stinner <vstinner@python.org>
@kumaraditya303
fix imports
c9beebe
@rhettinger rhettinger self-assigned this Oct 31, 2022
@rhettinger
Copy link
Contributor

Looks good. Thanks for the bug report and patch.

@rhettinger rhettinger merged commit ab57505 into python:main Nov 1, 2022
@miss-islington
Copy link
Contributor

Thanks @kumaraditya303 for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2022
@kumaraditya303 @miss-islington
pythonGH-98897: fix memory leak if math.dist raises exception (pyth…
517f8c9 
…onGH-98898)

(cherry picked from commit ab57505)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98941 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2022
@kumaraditya303 @miss-islington
pythonGH-98897: fix memory leak if math.dist raises exception (pyth…
6f7c90a 
…onGH-98898)

(cherry picked from commit ab57505)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98942 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 1, 2022
miss-islington added a commit that referenced this pull request Nov 1, 2022
@miss-islington @kumaraditya303
GH-98897: fix memory leak if math.dist raises exception (GH-98898)
8495af8 
(cherry picked from commit ab57505)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 1, 2022
@miss-islington @kumaraditya303
GH-98897: fix memory leak if math.dist raises exception (GH-98898)
078ce68 
(cherry picked from commit ab57505)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 deleted the math-dist branch November 1, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@rhettinger rhettinger

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303 @rhettinger @miss-islington @bedevere-bot @vstinner