KEMBAR78
GH-90699: Remove `_Py_IDENTIFIER` usage from `_elementtree` module by kumaraditya303 · Pull Request #99012 · python/cpython · GitHub
Skip to content

GH-90699: Remove _Py_IDENTIFIER usage from _elementtree module #99012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 2, 2022
Merged

GH-90699: Remove _Py_IDENTIFIER usage from _elementtree module #99012

merged 3 commits into from
Nov 2, 2022

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 2, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:ericsnowcurrently

@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Closed
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303
Copy link
Contributor Author

Merging main for #98988

@kumaraditya303
Copy link
Contributor Author

Okay so finally CI passed so good to merge.

@miss-islington miss-islington merged commit 908e81f into python:main Nov 2, 2022
@ericsnowcurrently ericsnowcurrently removed their assignment Nov 2, 2022
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-emscripten node (pthreads) 3.x has failed when building commit 908e81f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1050/builds/720) and take a look at the build logs.
  4. Check if the failure is related to this commit (908e81f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1050/builds/720

Failed tests:

  • test_traceback

Failed subtests:

  • test_import_from_error_bad_suggestions_do_not_trigger_for_small_names - test.test_traceback.PurePythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names

Summary of the results of the build (if available):

== Tests result: FAILURE ==

341 tests OK.

10 slowest tests:

  • test_tokenize: 1 min 22 sec
  • test_unparse: 51.0 sec
  • test_lib2to3: 50.6 sec
  • test_io: 36.1 sec
  • test_capi: 35.5 sec
  • test_unicodedata: 26.3 sec
  • test_argparse: 22.9 sec
  • test_pickle: 22.5 sec
  • test_decimal: 20.4 sec
  • test_statistics: 18.2 sec

1 test failed:
test_traceback

95 tests skipped:
test__xxsubinterpreters test_asyncgen test_asynchat test_asyncio
test_asyncore test_check_c_globals test_clinic test_cmd_line
test_concurrent_futures test_contextlib_async test_ctypes
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_doctest
test_docxmlrpc test_dtrace test_embed test_epoll test_faulthandler
test_fcntl test_file_eintr test_fork1 test_ftplib test_gdb
test_grp test_httplib test_httpservers test_idle test_imaplib
test_interpreters test_ioctl test_kqueue test_launcher test_lzma
test_mmap test_msilib test_multiprocessing_fork
test_multiprocessing_forkserver test_multiprocessing_main_handling
test_multiprocessing_spawn test_nis test_openpty test_ossaudiodev
test_pdb test_perf_profiler test_poll test_poplib test_pty
test_pwd test_readline test_regrtest test_repl test_resource
test_select test_selectors test_smtplib test_smtpnet test_socket
test_socketserver test_spwd test_ssl test_stable_abi_ctypes
test_startfile test_subprocess test_sys_settrace test_syslog
test_tcl test_telnetlib test_tix test_tkinter test_tools test_ttk
test_ttk_textonly test_turtle test_urllib2 test_urllib2_localnet
test_urllib2net test_urllibnet test_venv test_wait3 test_wait4
test_webbrowser test_winconsoleio test_winreg test_winsound
test_wmi test_wsgiref test_xmlrpc test_xmlrpc_net test_xxlimited
test_zipfile64 test_zipimport_support test_zoneinfo
0:23:37 load avg: 8.34
0:23:37 load avg: 8.34 Re-running failed tests is not supported with --python host runner option.

Total duration: 23 min 37 sec

Click to see traceback logs 
TracebackFormatTests.test_exception_group_deep_recursion_traceback) ... ok


TracebackFormatTests.test_exception_group_deep_recursion_capi) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_bin_op) ... ok


TracebackErrorCaretTests.test_multiline_method_call_c) ... ok


TracebackErrorCaretTests.test_byte_offset_multiline) ... ok


TracebackCases.test_nocaret) ... ok


TracebackFormatTests.test_print_stack) ... ok


TracebackFormatTests.test_traceback_format_with_cleared_frames) ... ok


TracebackCases.test_clear) ... ok


TracebackCases.test_print_exception_exc) ... ok


TracebackException_ExceptionGroups.test_comparison) ... ok


TracebackErrorCaretTests.test_decorator_application_lineno_correct) ... ok


TracebackCases.test_base_exception) ... ok


TracebackCases.test_recursion_error_during_traceback) ... skipped 'requires subprocess support'


TracebackCases.test_encoded_file) ... skipped 'requires subprocess support'


TracebackException.test_lookup_lines) ... ok


TracebackErrorCaretTests.test_traceback_very_long_line) ... ok


TracebackErrorCaretTests.test_multiline_method_call_a) ... ok


TracebackException_ExceptionGroups.test_exception_group_format_exception_only) ... ok


TracebackFormatTests.test_print_exception_bad_type_python) ... ok


TracebackException.test_unhashable) ... ok


TracebackException.test_smoke) ... ok


TracebackCases.test_print_traceback_at_exit) ... skipped 'requires subprocess support'


TracebackException.test_compact_no_cause) ... ok


TracebackCases.test_format_exception_exc) ... ok


TracebackCases.test_print_exception) ... ok


TracebackException.test_from_exception) ... ok


TracebackException_ExceptionGroups.test_max_group_depth) ... ok


TracebackErrorCaretTests.test_line_with_unicode) ... ok


TracebackCases.test_extract_stack) ... ok


Traceback (most recent call last):
  File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test_traceback.py", line 3139, in test_import_from_error_bad_suggestions_do_not_trigger_for_small_names
    self.assertNotIn("mom", actual)
AssertionError: 'mom' unexpectedly found in "ImportError: cannot import name 'b' from 'yeKfAfyAvlLqVTuN' (/tmp/tmpietmomml/yeKfAfyAvlLqVTuN.py)"


TracebackErrorCaretTests.test_traceback_specialization_with_syntax_error) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_syntax_error) ... ok


TracebackCases.test_format_exception_only_exc) ... ok


TracebackErrorCaretTests.test_caret_for_subscript) ... ok


TracebackException.test_cause) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators_two_char) ... ok


TracebackException.test_comparison_basic) ... ok


TracebackException.test_compact_with_cause) ... ok


TracebackException.test_no_refs_to_exception_and_traceback_objects) ... ok


TracebackException.test_print) ... ok


TracebackException_ExceptionGroups.test_exception_group_format) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag) ... skipped 'requires subprocess support'


TracebackException.test_context) ... ok


TracebackException.test_comparison_params_variations) ... ok


TracebackException.test_comparison_equivalent_exceptions_are_equal) ... ok


TracebackException_ExceptionGroups.test_max_group_width) ... ok


TracebackErrorCaretTests.test_byte_offset_with_wide_characters_middle) ... ok


TracebackErrorCaretTests.test_caret_exception_group) ... ok


TracebackException.test_no_locals) ... ok


TracebackCases.test_bad_indentation) ... ok


TracebackFormatTests.test_traceback_format) ... ok


TracebackErrorCaretTests.test_secondary_caret_not_elided) ... ok


TracebackErrorCaretTests.test_specialization_variations) ... ok


TracebackException.test_traceback_header) ... ok


TracebackErrorCaretTests.test_multiline_method_call_b) ... ok


TracebackFormatTests.test_print_exception_bad_type_capi) ... ok


TracebackCases.test_caret) ... ok


TracebackFormatTests.test_recursive_traceback_python) ... ok


TracebackException.test_limit) ... ok


TracebackErrorCaretTests.test_basic_caret) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression) ... ok


TracebackFormatTests.test_format_stack) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators) ... ok


TracebackErrorCaretTests.test_caret_in_type_annotation) ... ok


TracebackException.test_long_context_chain) ... ok


TracebackErrorCaretTests.test_wide_characters_unicode_with_problematic_byte_offset) ... ok


TracebackCases.test_format_exception_only_bad__str__) ... ok


TracebackCases.test_exception_is_None) ... ok


TracebackException_ExceptionGroups.test_exception_group_construction) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag_python_traceback) ... skipped 'requires subprocess support'


TracebackCases.test_signatures) ... ok


TracebackFormatTests.test_recursive_traceback_cpython_internal) ... ok


TracebackFormatTests.test_stack_format) ... ok


TracebackFormatTests.test_unhashable) ... ok


TracebackException.test_locals) ... ok

@kumaraditya303 kumaraditya303 deleted the etree branch November 3, 2022 09:22
@erlend-aasland erlend-aasland mentioned this pull request Jan 20, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 20, 2023
@erlend-aasland
pythonGH-90699: Clear interned strings in _elementtree
e487005 
Interned strings were added in pythonGH-99012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303 @bedevere-bot @ericsnowcurrently @miss-islington