KEMBAR78
GH-66285: skip asyncio fork tests for platforms without md5 hash by kumaraditya303 · Pull Request #99745 · python/cpython · GitHub
Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 24, 2022

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit d450015 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 24, 2022
@kumaraditya303 kumaraditya303 requested a review from ambv November 24, 2022 11:38
@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Nov 24, 2022

This fixes https://buildbot.python.org/all/#/builders/469/builds/3768

Other tests which use multiprocessing also skips test with this decorator.

@hashlib_helper.requires_hashdigest('md5')

The refleaks are unrelated.

@gvanrossum
Copy link
Member

Doesn’t seem to have helped. Let’s roll back the other and start over.

@kumaraditya303
Copy link
Contributor Author

@gvanrossum: The previously broken builtbot now passes with this PR https://buildbot.python.org/all/#/builders/713/builds/844. The refleaks exists on main too and is unrelated, see @ambv message on discord python-dev. Do you see any other issue with this?

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. Once we have conformation from @ambv this can be merged.

@gvanrossum gvanrossum merged commit 679d963 into python:main Nov 24, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 24, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 25, 2022
python#99745)

Such buildbots (at the time of writing, only "AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x") cannot use multiprocessing with a fork server, so just skip the test there.
@kumaraditya303 kumaraditya303 deleted the fix-bots branch November 28, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants