KEMBAR78
gh-99934: test_marshal.py: add more elements in test_deterministic_sets by kanavin · Pull Request #99935 · python/cpython · GitHub
Skip to content

gh-99934: test_marshal.py: add more elements in test_deterministic_sets #99935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2022
Merged

gh-99934: test_marshal.py: add more elements in test_deterministic_sets #99935

merged 1 commit into from
Dec 3, 2022

Conversation

@kanavin
Copy link
Contributor

@kanavin kanavin commented Dec 1, 2022 •
edited by bedevere-bot
Loading

Existing elements do produce different output on x86_64, but they do not on x86. Let's make the data longer to ensure it differs.

@kanavin kanavin requested a review from tiran as a code owner December 1, 2022 18:53
@bedevere-bot bedevere-bot mentioned this pull request Dec 1, 2022
Closed
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Dec 1, 2022
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Dec 1, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@kanavin
pythongh-99934: test_marshal.py: add more elements in test_determinis…
ee02c85 
…tic_sets

Existing elements do produce different output on x86_64, but they
do not on x86. Let's make the data longer to ensure it differs.
@rhettinger rhettinger added the needs backport to 3.11 only security fixes label Dec 3, 2022
@rhettinger rhettinger merged commit c68573b into python:main Dec 3, 2022
@miss-islington
Copy link
Contributor

Thanks @kanavin for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-99972 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 3, 2022
@kanavin @miss-islington
pythongh-99934: test_marshal.py: add more elements in test_determinis…
e55491c 
…tic_sets (pythonGH-99935)

Existing elements do produce different output on x86_64, but they
do not on x86. Let's make the data longer to ensure it differs.
(cherry picked from commit c68573b)

Co-authored-by: Alexander Kanavin <alex.kanavin@gmail.com>
miss-islington added a commit that referenced this pull request Dec 3, 2022
@miss-islington @kanavin
gh-99934: test_marshal.py: add more elements in test_deterministic_se…
4710a75 
…ts (GH-99935)

Existing elements do produce different output on x86_64, but they
do not on x86. Let's make the data longer to ensure it differs.
(cherry picked from commit c68573b)

Co-authored-by: Alexander Kanavin <alex.kanavin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kanavin @bedevere-bot @miss-islington @rhettinger