[mypyc] Add LoadLiteral and use tables to construct and store literals, try 2 #10147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10040) Redesign the implementation of constant `PyObject *` values, such as string and integer literals. There are several related changes: * Add `LoadLiteral` op for loading literal values instead of using `LoadStatic`. * No longer store all literals in a table while we construct IR to make it easier to remove literals no longer needed after optimizations in the future. * Simplify the pretty-printed IR for loading literals. * Rename the helpers used to construct literal references (e.g. `load_static_unicode` -> `load_str`). * Collect all used literals values after we have final IR. * Store literal value initialization information in C arrays instead of generating code for each value. * Store constructed literal objects in a single `CPyStatics` array. The goal is to speed up compiles (slightly) and to make it easy to support tuple literals and efficient table-driven import statements. Both of these can use the `CPyStatics` array. Closes mypyc/mypyc#794. Closes mypyc/mypyc#797.
This hopefully helps with MSVC build failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my second attempt to land this. See the first attempt (#10040) for the details.
Previously this broke Windows wheel builds. The change from the first attempt is that
instead of generating long static C strings, we generate arrays of shorter strings.