Consider reversed operands order when comparing version info #10288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Apr 8, 2021
mypy/reachability.py
Outdated
| index = contains_sys_version_info(expr.operands[1]) | ||
| thing = contains_int_or_tuple_of_ints(expr.operands[0]) | ||
| op = reverse_op[op] | ||
| if index is None or thing is None: |
There was a problem hiding this comment.
This check is redundant, since the conditions below won't trigger if either value is None.
There was a problem hiding this comment.
That's right. Good point 👍
JelleZijlstra
requested changes
Apr 8, 2021
JelleZijlstra
approved these changes
Apr 8, 2021
|
@JelleZijlstra One job on Travis CI has failed for some weird reason, doesn't look like thing related to this PR. |
|
Yeah that looks harmless. I'll merge this PR, thanks for your contributions! |
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Apr 10, 2021
Consider reversed operands order when comparing version info (python#10288)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #10264.
Consider reversed order of operands when trying to compare version info. When reversed order is used, operator is reversed as well for correct comparison.