stubgen: never generate variable initializer #10623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the generation of a variable initialized (= ...) was inconsistent between top-level and class-level variables. Since the initializer has no function in stubs, stubgen will now never generate it.
hauntsaninja
approved these changes
Jun 10, 2021
JelleZijlstra
approved these changes
Jun 10, 2021
|
Gentle ping. If this is merged, I can merge it into #10626. |
|
Pong! |
JukkaL
pushed a commit
that referenced
this pull request
Jun 21, 2021
Previously, the generation of a variable initialized (= ...) was inconsistent between top-level and class-level variables. Since the initializer has no function in stubs, stubgen will now never generate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the generation of a variable initialized (
= ...) wasinconsistent between top-level and class-level variables. Since the
initializer has no function in stubs, stubgen will now never generate
it.
Test Plan
Existing unit tests were updated.