Allow plugin signature hooks to return FunctionLike #10717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the type of the get_method_signature_hook and get_function_signature_hook plugin hooks to allow them to return any FunctionLike type, instead of just CallableType. This allows plugins to return Overloaded for the type of a function.
pranavrajpal
added a commit
to pranavrajpal/mypy
that referenced
this pull request
Jun 26, 2021
Change the return type of the plugin hook for determining the signature of a singledispatch function when it's called to FunctionLike. That allows us to return Overloaded without needing a 'type: ignore' comment, which should prevent mypyc from throwing an exception when it sees the wrong type. This change should be possible now that python#10717 has been merged.
pranavrajpal
added a commit
to pranavrajpal/mypy
that referenced
this pull request
Jun 29, 2021
Change the return type of the plugin hook for determining the signature of a singledispatch function when it's called to FunctionLike. That allows us to return Overloaded without needing a 'type: ignore' comment, which should prevent mypyc from throwing an exception when it sees the wrong type. This change should be possible now that python#10717 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
get_method_signature_hookandget_function_signature_hookplugin hooks to let them return anyFunctionLiketype instead of limiting them to justCallableType.This allows plugins to return
Overloadedfor the signature of a function, which is useful if there are multiple possible signatures for a specific function or method call, and the one that gets used is only determined at runtime. This situation came up when working on the singledispatch plugin from #10694.