Show warning if self / cls arguments are missing
#11317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas.git)
+ pandas/core/indexes/frozen.py:108: error: unused "type: ignore" comment
+ pandas/core/indexes/frozen.py:109: error: unused "type: ignore" comment
aioredis (https://github.com/aio-libs/aioredis.git)
- aioredis/client.py:4326: note: def (self: Redis) -> Any
+ aioredis/client.py:4326: note: def initialize(self: Redis) -> Any
ibis (https://github.com/ibis-project/ibis.git)
+ ibis/backends/parquet/tests/conftest.py:21: note: Looks like the first special argument in a method is not named "self", "cls", or "mcs", maybe it is missing?
+ ibis/backends/hdf5/tests/conftest.py:19: note: Looks like the first special argument in a method is not named "self", "cls", or "mcs", maybe it is missing?
+ ibis/backends/dask/tests/conftest.py:26: note: Looks like the first special argument in a method is not named "self", "cls", or "mcs", maybe it is missing?
+ ibis/backends/csv/tests/conftest.py:22: note: Looks like the first special argument in a method is not named "self", "cls", or "mcs", maybe it is missing?
- ibis/backends/dask/__init__.py:66: note: def compile(expr: Any, *args: Any, **kwargs: Any) -> Any
+ ibis/backends/dask/__init__.py:66: note: def compile(self, expr: Any, *args: Any, **kwargs: Any) -> Any
- ibis/backends/base/sql/alchemy/__init__.py:104: note: def connect(**options: Any) -> Any
+ ibis/backends/base/sql/alchemy/__init__.py:104: note: def connect(connection_string, **options: Any) -> Any
|
|
@JelleZijlstra could you please take a look? 🙂 |
|
Thank you! The pandas mypy-primer change makes it look like you fixed an unrelated bug too. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see what tests will be affected! 👀
Closes #11309