Allow mypy to run self check on PyPy #11350
Conversation
Yeah I'll open a follow up issue to do that, but for now Github actions doesn't support PyPy 3.8 (it is still in beta to be fair) so we will have to wait. I also added a slight tweak to the FAQ about PyPy 3.8 |
|
This is great news. The setup-python github action supports any pypy in pypy's versions.json, so you should be able to add a |
| pytest-forked>=1.3.0,<2.0.0 | ||
| pytest-cov>=2.10.0,<3.0.0 | ||
| py>=1.5.2 | ||
| typed_ast>=1.4.0,<1.5.0; python_version>='3.8' |
There was a problem hiding this comment.
No, we still need typed_ast for the Python 2 tests even on newer Python 3.xs
There was a problem hiding this comment.
hmm, so eventually there will be some acrobatics needed to exclude pypy and skip those tests
typed_ast>=1.4.0,<1.5.0; python_version>='3.8' and platform_python_implementation != 'PyPy'
There was a problem hiding this comment.
Yes :/ for now we are just going to run mypy on itself. At some point we can look into actual test coverage, but wheels for dependencies like lxml and psutil aren't available on Windows so that's already an issue.
A few lines change required to have mypy run on PyPy, to the extent that it can run self-check. Note this requires the new PyPy 3.8 beta to work. I don't expect tests to pass because things like lxml and such are not available for PyPy, so I don't think we should integrate testing (yet).
4 participants
Description
A few lines change required to have mypy run on PyPy, to the extent that it can run self-check. Note this requires the new PyPy 3.8 beta to work.
Test Plan
None.
I don't expect tests to pass because things like lxml and such are not available for PyPy, so I don't think we should integrate testing (yet).