Check duplicate bases when defining TypedDict #11485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy/semanal_typeddict.py
Outdated
| typeddict_bases = [] | ||
| typeddict_bases_set = set() | ||
| for expr in defn.base_type_exprs: | ||
| if (not isinstance(expr, RefExpr) or |
There was a problem hiding this comment.
I feel like there's two many nots here for this code to be readable. It looks like there are three cases: (1) the base class is TypedDict of some sort (expr.fullname in TPDICT_NAMES); (2) the base class is another TypedDict; (3) anything else, which produces an error. The code would be more readable if we covered those three cases in order, without any nots.
JelleZijlstra
approved these changes
Nov 8, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
### Description Closes python#3673 Adds a trivial for-loop and a helper set to check duplicates of `typeddict_bases`. ## Test Plan Adds a new test case `testCannotCreateTypedDictWithDuplicateBases`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3673
Adds a trivial for-loop and a helper set to check duplicates of
typeddict_bases.Test Plan
Adds a new test case
testCannotCreateTypedDictWithDuplicateBases