KEMBAR78
Fix crash involving undefined cyclic `import *` by hauntsaninja · Pull Request #11681 · python/mypy · GitHub
Skip to content

Conversation

hauntsaninja
Copy link
Collaborator

Fixes #11064. Co-authored by @hi-ogawa

Pushes #11346 over the finish line. Implements the suggestion in #11346 (review)

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Crashes involving import cycles can be a pain to debug, so this is much appreciated.

@JukkaL JukkaL merged commit b640914 into python:master Dec 13, 2021
@hauntsaninja hauntsaninja deleted the placehold branch December 15, 2021 00:32
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Fixes python#11064. Co-authored by @hi-ogawa 

Pushes python#11346 over the finish line. Implements the suggestion in 
python#11346 (review)

Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com>
Co-authored-by: hauntsaninja <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantic analysis deferral crash

3 participants