Fixes bool and Literal[True, False] subtyping, refs #11701
#11709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Awesome, thanks for this. #10389 was super useful, so glad we're fixing regressions.
Seems like this logic is coupled to try_expanding_sum_type_to_union, we should probably put a comment in both places
|
thanks for fixing this! |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
…ython#11709) In some places in our code bool was compared with `Union[Literal[True], Literal[False]]`. It was later compared with each union item. And bool is not subtype of `Literal[True]` and `Literal[False]`. Closes python#11701 Refs python#11705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places in our code
boolwas compared withUnion[Literal[True], Literal[False]].It was later compared with each union item. And
boolis not subtype ofLiteral[True]andLiteral[False]Closes #11701
Refs #11705