stubgen: Use _typeshed.Incomplete instead of typing.Any #12449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since python/typeshed#7535, typeshed has a new type `_typeshed.Incomplete`, intended to mark fields that are partly annotated, but need more manual investigation. This applies to all types generated by stubgen, except when explicitly annotated with `Any` in the implementation.
This comment has been minimized.
This comment has been minimized.
|
I'm not sure why the primer run failed. |
JelleZijlstra
approved these changes
Mar 25, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since python/typeshed#7535, typeshed has a new type
_typeshed.Incomplete,intended to mark fields that are partly annotated, but need more manual
investigation. This applies to all types generated by stubgen, except
when explicitly annotated with
Anyin the implementation.Test Plan
I changed all stubgen tests to use
Incompleteinstead ofAny, excepttestExplicitAnyArgandtestExplicitReturnedAnythat checked explicitAnyannotations. These tests were kept as is.