mypyc build: when windows use correct optimization and debug flags #12468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
changed the title
|
Passing |
KotlinIsland
changed the title
|
Is it still not expected to fix CI? |
|
I wouldn't expect it to. CI is being tracked here: #12460 |
|
Okay, was just checking to make sure I'm not merging something broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Send some more accurate optimization and debug flags to msvc.
This shouldn't fix the broken CI, but I think it's still a good idea to send correct parameters
GCC:
-O0Reduce compilation time and make debugging produce the expected results. This is the default.-O/-O1Optimize. Optimizing compilation takes somewhat more time, and a lot more memory for a large function.-O2Optimize even more.-O3Optimize yet more.-OsOptimize for sizeMSVC:
/O1sets a combination of optimizations that generate minimum size code./O2sets a combination of optimizations that optimizes code for maximum speed./Oddisables optimization, to speed compilation and simplify debugging.here's some more info
Test Plan
N/A