Make ValuePattern non-exhaustive #12751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes behaviour of PatternChecker so that ValuePattern does not cover the entire type since it can catch only a single value. Signed-off-by: Štěpán Horáček <xhorace2@fi.muni.cz>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
May 9, 2022
Actually, I'm not sure if this is the case. The edge case that I was thinking about actually was fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes behaviour of
PatternChecker, so that dotted names do not cover the entire type.Since dotted names match only one value of the type, the returned
rest_typeshould also contain the type of the value.Fixes: #12545
Test Plan
Included code similar to the one from the issue, modified into one file.