Fix custom typeshed dir handling by is_typeshed_file() #13629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Sep 8, 2022
added 2 commits
September 8, 2022 19:30
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
jhance
pushed a commit
that referenced
this pull request
Sep 9, 2022
This was broken by #13155, fix is straightforward, pass custom typeshed dir from options everywhere. Co-authored-by: Ivan Levkivskyi <ilevkivskyi@dropbox.com>
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Sep 12, 2022
Fixes python#13654, caused by python#13629
hauntsaninja
added a commit
that referenced
this pull request
Sep 13, 2022
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #13155, fix is straightforward, pass custom typeshed dir from options everywhere.