Update 'typing_extensions' to >=4.6.0 to fix python 3.12 error #17312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With earlier versions of typing_extensions, the following traceback is
seen:
```
Traceback (most recent call last):
File ".../bin/mypy", line 5, in <module>
from mypy.__main__ import console_entry
File ".../lib/python3.12/site-packages/mypy/__main__.py", line 9, in <module>
from mypy.main import main, process_options
File ".../lib/python3.12/site-packages/mypy/main.py", line 12, in <module>
from typing_extensions import Final
File ".../lib/python3.12/site-packages/typing_extensions.py", line 1174, in <module>
class TypeVar(typing.TypeVar, _DefaultMixin, _root=True):
TypeError: type 'typing.TypeVar' is not an acceptable base type
```
The error is addressed in typing_extensions in
python/typing_extensions#162, which is included
in the 4.6.0 release.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
GiorgosPapoutsakis
pushed a commit
to GiorgosPapoutsakis/mypy
that referenced
this pull request
Jun 3, 2024
…n#17312) With earlier versions of typing_extensions, the following traceback is seen: ``` Traceback (most recent call last): File ".../bin/mypy", line 5, in <module> from mypy.__main__ import console_entry File ".../lib/python3.12/site-packages/mypy/__main__.py", line 9, in <module> from mypy.main import main, process_options File ".../lib/python3.12/site-packages/mypy/main.py", line 12, in <module> from typing_extensions import Final File ".../lib/python3.12/site-packages/typing_extensions.py", line 1174, in <module> class TypeVar(typing.TypeVar, _DefaultMixin, _root=True): TypeError: type 'typing.TypeVar' is not an acceptable base type ``` The error is addressed in typing_extensions in python/typing_extensions#162, which is included in the 4.6.0 release.
GiorgosPapoutsakis
pushed a commit
to GiorgosPapoutsakis/mypy
that referenced
this pull request
Jun 3, 2024
…places (python#17313) Followup to python#17312. (Can't say I fully understand why we have to have this pin in three places :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With earlier versions of typing_extensions, the following traceback is seen:
The error is addressed in typing_extensions in
python/typing_extensions#162, which is included
in the 4.6.0 release.
(Explain how this PR changes mypy.)