KEMBAR78
Fix incorrect truthyness for Enum types and literals by Daverball · Pull Request #17337 · python/mypy · GitHub
Skip to content

Fix incorrect truthyness for Enum types and literals #17337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 14, 2024
Merged

Fix incorrect truthyness for Enum types and literals #17337

merged 16 commits into from
Nov 14, 2024

Conversation

@Daverball
Copy link
Contributor

@Daverball Daverball commented Jun 6, 2024 •
edited
Loading

Fixes: #17333

This ensures can_be_true and can_be_false on enum literals depends on the specific Enum fallback type behind the Literal, since __bool__ can be overriden like on any other type.

Additionally typeops true_only and false_only now respect the metaclass when looking up the return values of __bool__ and __len__, which ensures that a default Enum that doesn't override __bool__ is still considered always truthy.

@github-actions

This comment has been minimized.

Sign in to view
@Daverball

This comment was marked as resolved.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Daverball
Copy link
Contributor Author

BTW I found it a little concerning that TypeInfo.get and TypeInfo.get_method only consider the mro and not the metaclass when looking up symbols, but I didn't have the stomach to change this, since there probably is code that depends on this behavior.

I fear however that there are quite a few more places where attribute lookups are incorrect (other than the one I have fixed in this PR), because the attribute is defined on the metaclass and not on the class itself. Should we perhaps create an issue to potentially review call sites of get/clean this up/improve documentation to avoid more errors in the future?

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Daverball
Copy link
Contributor Author

@hauntsaninja Not asking for a review (although that would be nice too), but for your thoughts on my comment above: #17337 (comment)

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Re your comment: I think most attribute lookups should go through analyze_member_access

@hauntsaninja hauntsaninja merged commit fa01a07 into python:master Nov 14, 2024
19 checks passed
@hauntsaninja hauntsaninja mentioned this pull request Dec 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Truthyness inference incorrect for some Enum types

2 participants

@Daverball @hauntsaninja