KEMBAR78
Do not require explicit override for plugin-generated methods by sterliakov · Pull Request #17370 · python/mypy · GitHub
Skip to content

Do not require explicit override for plugin-generated methods #17370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not require explicit override for plugin-generated methods #17370

wants to merge 1 commit into from

Conversation

@sterliakov
Copy link
Collaborator

Closes #17224.

Ensure that explicit-override error is never applied to functions which are not present in source code (generated by plugin), because there is no place to apply override.

@sterliakov
Copy link
Collaborator Author

I hope that tox internal failure is not caused by my interference...

@github-actions

This comment has been minimized.

Sign in to view
@sterliakov
Copy link
Collaborator Author

sterliakov commented Jun 12, 2024 •
edited
Loading

It's transitive filelock dependency upgrade: current CI fails with 3.15.0, but succeeds with 3.14.0. I was able to reproduce this problem locally, pinning to filelock != 3.15.0 resolves the tox run problem. Would it be appropriate to add such a pin to this pull request (that breaks the "one change per PR" rule, but probably "internal dependency pin in CI" isn't that important)? Should I submit it separately (or probably investigate deeper)? Probably nothing, filelock maintainers are already engaged and work on this.

@sterliakov
Copy link
Collaborator Author

Cross-ref: tox-dev/filelock#337

@AlexWaygood AlexWaygood reopened this Jun 12, 2024
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@cdce8p cdce8p mentioned this pull request Jun 24, 2024
Merged
sobolevn added a commit that referenced this pull request Jun 24, 2024
@sobolevn
Take a test case from #17370
1d0ac49
@sobolevn sobolevn closed this in 620e281 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subclass using @dataclass(order=True) have unavoidable "not using @override" error for __lt__ etc, with --enable-error-code=explicit-override

2 participants

@sterliakov @AlexWaygood