KEMBAR78
[docs] Fix metaclass usage example by Geo5 · Pull Request #18686 · python/mypy · GitHub
Skip to content

Conversation

Geo5
Copy link
Contributor

@Geo5 Geo5 commented Feb 16, 2025

Fixes #18668

  • Fixed the code example to not include Self
  • Added a note about Self & metaclasses in Gotchas section with a link to the relevant PEP

- Added a note about Self & metaclasses in Gotchas section
Copy link
Collaborator

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@sobolevn sobolevn merged commit d87f0b2 into python:master Feb 19, 2025
2 checks passed
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
Fixes python#18668 

- Fixed the code example to _not_ include `Self`
- Added a note about `Self` & metaclasses in Gotchas section with a link
to the relevant PEP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metaclass Usage Example Code Incorrect

3 participants