Add an option to exclude everything in .gitignore #18696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I think there are some edge cases this will not handle correctly, like nested gitignore where inner gitignore has a negated pattern. But this is pretty niche. I have a library that makes it easier to handle this stuff than pathspec (and is also faster), maybe I will open source
This is very niche. |
|
Diff from mypy_primer, showing the effect of this PR on open source code: django-stubs (https://github.com/typeddjango/django-stubs): 1.90x faster (46.9s -> 24.6s in a single noisy sample)
Tanjun (https://github.com/FasterSpeeding/Tanjun): 1.60x slower (77.8s -> 124.7s in a single noisy sample)
|
hauntsaninja
approved these changes
Feb 18, 2025
x612skm
pushed a commit
to x612skm/mypy-dev
that referenced
this pull request
Feb 24, 2025
Fixes python#12505 This is (somewhat surprisingly) one of the most upvoted issues, and looks like a simple thing to add. I essentially do what other tools do, but optimize for how we work with sources discovery (to avoid performance issues). I am making this opt-in for now, we can change this later if needed.
|
Assuming I'm not missing anything, when are we expected to get this released? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12505
This is (somewhat surprisingly) one of the most upvoted issues, and looks like a simple thing to add. I essentially do what other tools do, but optimize for how we work with sources discovery (to avoid performance issues). I am making this opt-in for now, we can change this later if needed.