dmypy suggest can now suggest through contextmanager-based decorators #18948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
force-pushed
the
mypy-suggest-contextmanager
branch
from
737c5ac to
0db2c46
Compare
asottile
force-pushed
the
mypy-suggest-contextmanager
branch
from
0db2c46 to
f921981
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
+ torchvision/utils.py:271: error: Unused "type: ignore" comment [unused-ignore]
|
asottile-sentry
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 22, 2025
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
andrewshie-sentry
pushed a commit
to getsentry/sentry
that referenced
this pull request
Apr 22, 2025
first commit automated via https://github.com/getsentry/auto-type-annotate - I used these patches to mypy: - python/mypy#18948 - (the line mentioned in the issue commented out): python/mypy#18940 (comment) - and with this unreverted (coming soon!): #89854 <!-- Describe your PR here. -->
sterliakov
approved these changes
May 2, 2025
pretty sure it's a race of another unrelated patch being merged and the use of |
|
I think mypy is nondeterministic on torchvision, see hauntsaninja/mypy_primer#161 mypy_primer uses the merge base on PRs, so the diff should be trustworthy |
hauntsaninja
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.