Remove force_uppercase_builtins default from test helpers #19173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
May 30, 2025
mypy/test/helpers.py
Outdated
| if m := re.search(r"python3([0-9]+)\.test$", path): | ||
| # For older unsupported version like python38, | ||
| # default to that earliest supported version. | ||
| return max((3, int(m.group(1))), defaults.PYTHON3_VERSION) |
There was a problem hiding this comment.
Should this use PYTHON3_VERSION_MIN?
There was a problem hiding this comment.
Tbh I wasn't sure myself. PYTHON3_VERSION_MIN makes sense, but in that case we should also use it as the default for all other test cases as well, not just those with -python3X. Pushed dcde1aa to adjust it.
cdce8p
force-pushed
the
tests-remove-force-uppercase-builtins
branch
from
0b70f03 to
dcde1aa
Compare
JukkaL
approved these changes
May 30, 2025
cdce8p
added a commit
to cdce8p/mypy
that referenced
this pull request
May 31, 2025
Mypy only supports Python 3.9+. Update the tests to use lowercase names for PEP 585 generics in error messages. A followup can consider deprecating `--force-uppercase-builtins` and making it a no-op.
JukkaL
pushed a commit
that referenced
this pull request
Jun 5, 2025
Use lowercase builtins for error messages, Mypy only supports 3.9+. This PR deprecates the `--force-uppercase-builtins` flag and makes it a no-op. Followup to #19173.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy only supports Python 3.9+. Update the tests to use lowercase names for PEP 585 generics in error messages. A followup can consider deprecating
--force-uppercase-builtinsand making it a no-op.