KEMBAR78
Update Fix help message url for "None and Optional handling" section by guywilsonjr · Pull Request #19252 · python/mypy · GitHub
Skip to content

Update Fix help message url for "None and Optional handling" section #19252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2025
Merged

Update Fix help message url for "None and Optional handling" section #19252

merged 1 commit into from
Jun 8, 2025

Conversation

guywilsonjr
Copy link
Contributor

Fixes #19251

Correct url in help message"None and Optional handling" group
Checklist:

  • Read the Contributing Guidelines
  • Add tests for all changed behaviour.
  • If you can't add a test, please explain why and how you verified your changes work.
$ mypy -h
....
None and Optional handling:
  Adjust how values of type 'None' are handled. For more context on how mypy handles values of type 'None', see:
  https://mypy.readthedocs.io/en/stable/kinds_of_types.html#optional-types-and-the-none-type
...
  • - Make sure CI passes.
  • - Please do not force push to the PR once it has been reviewed.

@A5rocks
Copy link
Collaborator

A5rocks commented Jun 8, 2025

Maybe it makes more sense to update the docs to support this old anchor, for people on older mypy versions?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Jun 8, 2025
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing! (Open to A5rocks idea in addition!)

@hauntsaninja hauntsaninja merged commit f1b496c into python:master Jun 8, 2025
19 checks passed
@ferdnyc ferdnyc mentioned this pull request Sep 9, 2025
Open
wyattscarpenter added a commit to wyattscarpenter/mypy that referenced this pull request Sep 11, 2025
@wyattscarpenter
Update kinds_of_types.rst: keep old anchor for #no-strict-optional
86daa49 
Not sure if this will work, since something else has the same anchor on a different page... See python#19252, though.
@wyattscarpenter wyattscarpenter mentioned this pull request Sep 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Help message URL incorrect for "None and Optional handling"

3 participants

@guywilsonjr @A5rocks @hauntsaninja