Generalize class/static method and property alias support #19297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Jun 16, 2025
|
|
||
| reveal_type(A().g) # N: Revealed type is "builtins.int" | ||
| reveal_type(A().g2) # N: Revealed type is "builtins.int" | ||
| A().g2 = 1 |
There was a problem hiding this comment.
Test assignment to A().g (should generate an error).
| def foo2(cls, x): | ||
| ... | ||
|
|
||
| bar2 = foo2 |
There was a problem hiding this comment.
Is it worth it to also test static methods? Did they already work?
There was a problem hiding this comment.
Static methods already worked, but not overloaded ones. I added a test specifically for overloaded static method.
mypy/checker.py
Outdated
| return t.copy_modified(args=[a.accept(self) for a in t.args]) | ||
|
|
||
|
|
||
| def is_node_class(node: Node | None) -> bool | None: |
There was a problem hiding this comment.
Nit: Maybe rename to is_classmethod_node or similar? My initial thought what that this checks if the target is a "node class".
|
Diff from mypy_primer, showing the effect of this PR on open source code: antidote (https://github.com/Finistere/antidote)
+ tests/core/test_inject_wrapper.py:228: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject_wrapper.py:234: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject_wrapper.py:240: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject_wrapper.py:336: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject_wrapper.py:342: error: Unused "type: ignore" comment [unused-ignore]
+ tests/core/test_inject_wrapper.py:348: error: Unused "type: ignore" comment [unused-ignore]
|
ilevkivskyi
pushed a commit
that referenced
this pull request
Aug 2, 2025
dangotbanned
added a commit
to narwhals-dev/narwhals
that referenced
this pull request
Aug 10, 2025
`from_modin` alias *should* type check okay after release w/ (python/mypy#19297) Keeping as-is, since `pyright` understands and `pylance` can re-use the docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6700
This is another followup for the
checkmemberwork. Currently, we only support non-instance method aliasing in few very specific cases. I am making this support general.