KEMBAR78
Fix serialization and deserialization of metaclasses by JukkaL · Pull Request #3328 · python/mypy · GitHub
Skip to content

Conversation

@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented May 5, 2017

This has some overlap with #3304.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I was going to propose exactly the same, merge this part of #3304 before the release, and everything else later. But this is even better since I forgot about metaclass_type in nodes.py.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JukkaL JukkaL merged commit 54f1df9 into master May 5, 2017
@gvanrossum gvanrossum deleted the fix-serialize-metaclass branch May 9, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants