Give better error message for ommited parens in function type #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Dec 6, 2017
mypy/fastparse.py
Outdated
| except SyntaxError: | ||
| self.fail(TYPE_COMMENT_SYNTAX_ERROR, n.lineno, n.col_offset) | ||
| if n.type_comment and n.type_comment[0] != "(": | ||
| self.note('Suggestion: wrap input types in parens', n.lineno, n.col_offset) |
There was a problem hiding this comment.
Have you tested what happens if there are extra spaces after # type:, such as # type:<space><space>int -> int?
Style nits: Use "argument types" instead of "input types". Spell parens as "parentheses".
There was a problem hiding this comment.
I tested it but probably should put a test for it into the test suite.
Roger.
gvanrossum
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #4323
The direct check for a paren feels janky, but I'm not sure if there is a nicer way.