Produce better error on invalid types like List(int) #4323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
requested changes
Dec 5, 2017
There was a problem hiding this comment.
I'd like to see a new test too that checks List(int), another for a user-defined generic class, and yet another proving that it works for Python 2 mode too.
Also, there are a few more related concerns brought up in #4172 -- can you look into fixing those too (if it's not too complicated)?
msullivan
force-pushed
the
invalid_msg
branch
from
6610d81 to
f3c27b2
Compare
|
Added some more tests, including a python3 one (the existing one was already python2). I'm taking a look at the other issues mentioned in the bug and will put up another PR for them. |
msullivan
pushed a commit
that referenced
this pull request
Dec 6, 2017
…omment Partially fixes #4323
msullivan
pushed a commit
that referenced
this pull request
Dec 6, 2017
JukkaL
pushed a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4172