KEMBAR78
Fix crash when checking async generator return type by ilevkivskyi · Pull Request #5123 · python/mypy · GitHub
Skip to content

Fix crash when checking async generator return type #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2018
Merged

Fix crash when checking async generator return type #5123

merged 1 commit into from
May 30, 2018

Conversation

@ilevkivskyi
Copy link
Member

Fixes #5122

A side note is that flag is_coroutine is a bit unfortunately named. It is still true for async generators. We could probably rename it to is_async at some point.

@ilevkivskyi ilevkivskyi merged commit 75a4014 into python:master May 30, 2018
@ilevkivskyi ilevkivskyi deleted the fix-async-gen branch May 30, 2018 22:15
msullivan pushed a commit that referenced this pull request May 31, 2018
@ilevkivskyi @msullivan
Fix crash when checking async generator return type (#5123)
1a553a4
@msullivan msullivan mentioned this pull request May 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ilevkivskyi @JelleZijlstra @gvanrossum