Namespaces refactor part 2 #5690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 28, 2018 08:44
JelleZijlstra
approved these changes
Sep 29, 2018
TV4Fun
pushed a commit
to TV4Fun/mypy
that referenced
this pull request
Oct 4, 2018
* Get rid of trivial type_check_only() function * Remove bin_dir -- it's no longer used * Fix wrong import in testcheck.py * Fix indent of compute_search_paths() args * Minor cleanup in mypy/test/testcheck.py * Cleanups in mypy/dmypy_server.py and mypy/server/ * Fix lint * Fix lint fix
97littleleaf11
added a commit
that referenced
this pull request
Aug 14, 2022
`script_path` was entirely useless since `bin_dir` had been dropped long time ago by #5690. This PR also makes arguments of mypy.main keyword-only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more mindless refactoring.
type_check_only()-- there was only one call and all it did was rearrange the argumentsbin_dirargument -- nothing uses it