Remove unused imports #5694
Merged
Remove unused imports #5694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Sep 29, 2018
mypy/checkexpr.py
Outdated
| true_only, false_only, is_named_instance, function_type, callable_type, FunctionLike, | ||
| get_typ_args, StarType | ||
| PartialType, DeletedType, UninhabitedType, TypeType, TypeOfAny, true_only, | ||
| false_only, is_named_instance, function_type, callable_type, FunctionLike, StarType |
There was a problem hiding this comment.
Can you add a trailing comma? In lists like this that's how we like to format them.
mypy/stats.py
Outdated
|
|
||
| from collections import Counter | ||
| from typing import Dict, List, cast, Optional | ||
| from typing import cast, Counter, Dict, List, Optional |
There was a problem hiding this comment.
This doesn't seem right. It overrides the import of Counter on the previous line. I think there's a reason why the code isn't doing that.
There was a problem hiding this comment.
Ah, you are correct. I missed this. Thanks for the helpful comment.
mypy/stats.py
Outdated
|
|
||
| from collections import Counter | ||
| from typing import Dict, List, cast, Optional | ||
| from typing import cast, Counter, Dict, List, Optional |
There was a problem hiding this comment.
This doesn't seem right. It overrides the import of Counter on the previous line. I think there's a reason why the code did what it did.
ceh
force-pushed
the
remove-unused-imports
branch
from
673c158 to
ea182ad
Compare
|
Thanks again! |
TV4Fun
pushed a commit
to TV4Fun/mypy
that referenced
this pull request
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.