KEMBAR78
Improve missing import message by Lewiscowles1986 · Pull Request #7698 · python/mypy · GitHub
Skip to content

Conversation

Lewiscowles1986
Copy link
Contributor

@Lewiscowles1986 Lewiscowles1986 commented Oct 11, 2019

It can be difficult to understand the missing module error message at times.

Changes

Cannot find module named '{}'

to

Cannot find implementation or library stub for module named '{}'

This improves #4542

Great thanks to all that participated in that discussion, this is all of our work.

@JukkaL

@Lewiscowles1986 Lewiscowles1986 force-pushed the improve-missing-import-message branch from 7e15a0b to bbb4871 Compare October 11, 2019 17:14
@Lewiscowles1986 Lewiscowles1986 marked this pull request as ready for review October 11, 2019 17:41
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, assuming we're hapy with the wording. @JukkaL?

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 28, 2019

Looks good!

@JukkaL JukkaL merged commit 70f2857 into python:master Oct 28, 2019
dmtucker added a commit to dmtucker/pytest-mypy that referenced this pull request Dec 29, 2019
francomattar added a commit to francomattar/Nmypy-pytest that referenced this pull request Dec 13, 2024
nayanzin33sergey added a commit to nayanzin33sergey/Python-pytest-mypy that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants