KEMBAR78
Fix __init_subclass__ type check by ilevkivskyi · Pull Request #7723 · python/mypy · GitHub
Skip to content

Fix __init_subclass__ type check #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix __init_subclass__ type check #7723

merged 1 commit into from
Oct 16, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #7722

This skips checking class keywords against __init_subclass__ for:

  • Classes with custom metaclasses, because they can pop the keywords before calling super().
  • Classes that are special forms, like TypedDict etc.

@ilevkivskyi ilevkivskyi requested a review from msullivan October 16, 2019 13:35
@msullivan
Copy link
Collaborator

Yeah, good catch. This will get cherry picked.

@msullivan msullivan merged commit 222b14d into python:master Oct 16, 2019
msullivan pushed a commit that referenced this pull request Oct 16, 2019
@ilevkivskyi @msullivan
Fix __init_subclass__ type check (#7723)
97d25cf
@tdamsma tdamsma mentioned this pull request Oct 17, 2019
Closed
@esoma esoma mentioned this pull request Sep 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msullivan msullivan Awaiting requested review from msullivan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: false positive when creating a TypedDict with total=False

2 participants

@ilevkivskyi @msullivan