Make logic around bind_self() consistent in different code paths #8021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8020
There is a bunch of code/logic duplication around
bind_self(), mostly because of #7724. This PR makes all three main code paths consistently follow the same structure:freshen_function_type_vars()bind_self()expand_type_by_instance(..., map_instance_to_supertype())(a.k.amap_type_from_supertype())I briefly scrolled through other code paths, and it looks like this was last major/obvious inconsistency (although code around
__getattr__/__setattr__/__get__/__set__looks a bit suspicious).