Use literal constant for QuotingType in csv Module
#13983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. Adjust type aliasing for better type safety in CSV quoting options.
max-muoto
changed the title
QuotingType for csv ModuleQuotingType in csv Module
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 10, 2025
Removed: 95d040d |
srittau
approved these changes
May 10, 2025
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/io/formats/csvs.py:264: error: Argument "quoting" to "writer" has incompatible type "int"; expected "Literal[0, 1, 2, 3]" [arg-type]
static-frame (https://github.com/static-frame/static-frame)
+ static_frame/core/frame.py:9096: error: Argument "quoting" to "writer" has incompatible type "int"; expected "Literal[0, 1, 2, 3, 4, 5]" [arg-type]
|
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
May 10, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mentioned moratorium is long over (#7258), and similar literals constants are commonly used in TypeShed at this point. Unless there's a major point of objection, and the fact that in most cases the constants are being directly passed into
csv.writer(...)the chance of false positives is pretty low.