Revert addition of class_getitem to PathLike #6591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in python#5869 This breaks all PathLike classes that don't have class_getitem
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Dec 16, 2021
Doing so would have caught python#6591
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 16, 2021
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
Dec 17, 2021
Backport of python/typeshed#6591 Co-authored-by: hauntsaninja <>
ilevkivskyi
pushed a commit
to python/mypy
that referenced
this pull request
Dec 21, 2021
Backport of python/typeshed#6591 Co-authored-by: hauntsaninja <>
This was referenced Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in #5869
This breaks all PathLike classes that don't have class_getitem