Fixes to curses stubs #6620
Merged
Fixes to curses stubs #6620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python/mypy#11768. I reviewed all the function definitions in https://github.com/python/cpython/blob/3.9/Modules/_cursesmodule.c#L4152 and checked their types. I did not review the constants or the methods on the Window object.
srittau
approved these changes
Dec 17, 2021
JelleZijlstra
commented
Dec 17, 2021
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
added a commit
to python/mypy
that referenced
this pull request
Dec 17, 2021
JelleZijlstra
added a commit
to JelleZijlstra/tornado
that referenced
this pull request
Dec 17, 2021
|
Diff from mypy_primer, showing the effect of this PR on open source code: tornado (https://github.com/tornadoweb/tornado)
+ tornado/log.py:154: error: Argument 1 to "str" has incompatible type "Optional[bytes]"; expected "bytes"
mypy (https://github.com/python/mypy)
+ mypy/util.py:573: error: Item "None" of "Optional[bytes]" has no attribute "decode" [union-attr]
|
hauntsaninja
pushed a commit
to python/mypy
that referenced
this pull request
Dec 17, 2021
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Dec 17, 2021
JukkaL
pushed a commit
to python/mypy
that referenced
this pull request
Dec 20, 2021
Solves #11768 in the 0.930 branch Found by python/typeshed#6620 Co-authored-by: hauntsaninja <> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes python/mypy#11768.
I reviewed all the function definitions in https://github.com/python/cpython/blob/3.9/Modules/_cursesmodule.c#L4152 and checked their types. I did not review the constants or the methods on the Window object.