KEMBAR78
Remove CPU support for lars_sgd by sryap · Pull Request #1774 · pytorch/FBGEMM · GitHub
Skip to content

Conversation

@sryap
Copy link
Contributor

@sryap sryap commented May 13, 2023

Differential Revision: D45845181

@netlify
Copy link

netlify bot commented May 13, 2023

Deploy Preview for pytorch-fbgemm-docs canceled.

Name Link
🔨 Latest commit 29bc6eb
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/64790c9bd07d9b00083ca6dc

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 15, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Differential Revision: D45845181

fbshipit-source-id: 5cd2e497ab021b32d85a58207c6dd14e69cef03a
@sryap sryap force-pushed the export-D45845181 branch from b3a9e67 to 6c244b3 Compare May 15, 2023 17:23
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 15, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Differential Revision: D45845181

fbshipit-source-id: 498e20ee1f0eae8123391906307465747534d1f6
@sryap sryap force-pushed the export-D45845181 branch from 6c244b3 to 6bbb0b2 Compare May 15, 2023 17:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 23, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: q10, csmiler

Differential Revision: D45845181

fbshipit-source-id: 1e1b9d8f97b118d986d32cfd65909ba0d4923246
@sryap sryap force-pushed the export-D45845181 branch from 6bbb0b2 to e34468e Compare May 23, 2023 16:52
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 23, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: q10, csmiler

Differential Revision: D45845181

fbshipit-source-id: da7d8ec0f8b5de7dd1fa5351edc19d141b4ce4dc
@sryap sryap force-pushed the export-D45845181 branch from e34468e to 8959ac0 Compare May 23, 2023 17:00
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 24, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: q10, csmiler

Differential Revision: D45845181

fbshipit-source-id: 715fe857a2cdcada9ae8e39e167383da463f34c3
@sryap sryap force-pushed the export-D45845181 branch from 8959ac0 to 420db40 Compare May 24, 2023 18:01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap added a commit to sryap/FBGEMM that referenced this pull request May 24, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: q10, csmiler

Differential Revision: D45845181

fbshipit-source-id: 0213bb5f850d6624bf204fd842a72955ad8c2324
@sryap sryap force-pushed the export-D45845181 branch from 420db40 to b62b0f1 Compare May 24, 2023 18:12
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap pushed a commit to sryap/FBGEMM that referenced this pull request Jun 1, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: csmiler

Differential Revision: D45845181

fbshipit-source-id: 6f3c6e7f6bbdfd19bd66641e2d0a2c2edd7a392b
@sryap sryap force-pushed the export-D45845181 branch from b62b0f1 to 62ca66f Compare June 1, 2023 06:13
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap pushed a commit to sryap/FBGEMM that referenced this pull request Jun 1, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: csmiler

Differential Revision: D45845181

fbshipit-source-id: 55a21845ee3f7d321ce0567cfbebacc9e7c3bbdb
@sryap sryap force-pushed the export-D45845181 branch from 62ca66f to 8907c79 Compare June 1, 2023 06:20
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

sryap pushed a commit to sryap/FBGEMM that referenced this pull request Jun 1, 2023
Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: csmiler

Differential Revision: D45845181

fbshipit-source-id: bc14f1b627ce5c9634a574f602c799f8c7e38192
@sryap sryap force-pushed the export-D45845181 branch from 8907c79 to c86a598 Compare June 1, 2023 21:19
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

Summary:
Pull Request resolved: pytorch#1774

This diff is a part of FBGEMM TBE optimizer deprecation plan (see
pytorch#1727)

Changes include:
- Setting `has_cpu_support` of `lars_sgd` to
  `False` in the code gen script
- Updating `codegen/TARGETS` and `CMakeLists.txt`

See D45835048 for how the changes affect the code generation

Reviewed By: csmiler

Differential Revision: D45845181

fbshipit-source-id: 2cf5f40f5aceea997a59eb1eef97b27da0fb4a18
@sryap sryap force-pushed the export-D45845181 branch from c86a598 to 29bc6eb Compare June 1, 2023 21:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D45845181

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 2cd10ef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants