Remove CPU and GPU support for approx_sgd (#1769) #1791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: pytorch#1769 This diff is a part of FBGEMM TBE optimizer deprecation plan (see pytorch#1727) Changes include: - Setting `has_cpu_support` and `has_gpu_support` of `approx_sgd` to `False` in the code gen script - Updating `codegen/TARGETS` and `CMakeLists.txt` See D45835048 for how the changes affect the code generation Reviewed By: csmiler Differential Revision: D45844197 fbshipit-source-id: a80615bbc654e13f6de32b49a18c48806b1df6bb
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D45844197 |
facebook-github-bot
pushed a commit
to facebookresearch/param
that referenced
this pull request
May 30, 2023
Summary: Pull Request resolved: #75 X-link: pytorch/FBGEMM#1791 X-link: pytorch/FBGEMM#1769 This diff is a part of FBGEMM TBE optimizer deprecation plan (see pytorch/FBGEMM#1727) Changes include: - Setting `has_cpu_support` and `has_gpu_support` of `approx_sgd` to `False` in the code gen script - Updating `codegen/TARGETS` and `CMakeLists.txt` See D45835048 for how the changes affect the code generation Reviewed By: louisfeng, csmiler Differential Revision: D45844197 fbshipit-source-id: 02f948913b11cb5cde377e2e0c2cf65756a723a3
|
This pull request has been merged in 60a3706. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is a part of FBGEMM TBE optimizer deprecation plan (see
#1727)
Changes include:
has_cpu_supportandhas_gpu_supportofapprox_sgdtoFalsein the code gen scriptcodegen/TARGETSandCMakeLists.txtSee D45835048 for how the changes affect the code generation
Reviewed By: csmiler
Differential Revision: D45844197