Make AVX Support Optional (#1698) #1795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
May 31, 2023
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: 35a1b605ee8503c5eb85783ca4b55030d296abc8
excelle08
force-pushed
the
export-D45139063
branch
from
2ae3789 to
48f6b01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 1, 2023
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Reviewed By: q10 Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: 561ccf4ef5eb7778ea6a3443b2f604216fb4542b
excelle08
force-pushed
the
export-D45139063
branch
from
48f6b01 to
2b0994e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 1, 2023
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Reviewed By: q10 Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: 86b5cc55c33861f09265746dda7427359a4db3e0
excelle08
force-pushed
the
export-D45139063
branch
from
2b0994e to
1faf2ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 1, 2023
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Reviewed By: q10 Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: d9f6660d84d6ed6add3742ecb58ee18c37d2591a
excelle08
force-pushed
the
export-D45139063
branch
from
1faf2ba to
dd825f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
excelle08
pushed a commit
to excelle08/FBGEMM
that referenced
this pull request
Jun 1, 2023
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Reviewed By: q10 Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: fa1c1065888630dc1e9b8ec84e4493be3565596e
excelle08
force-pushed
the
export-D45139063
branch
from
dd825f4 to
6438361
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
Summary: Pull Request resolved: pytorch#1795 - Add `FindAVX.cmake` from the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targets Pull Request resolved: pytorch#1698 Test Plan: On a devarm machine: - Set up the environment according to [the building instruction](https://github.com/pytorch/FBGEMM/blob/main/fbgemm_gpu/docs/BuildInstructions.md). For convenience we can source `.github/scripts/setup_env.bash` in the FBGEMM repo and run the functions in it. - Build and install CPU-only variant of fbgemm_gpu: # Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced cd fbgemm_gpu build_fbgemm_gpu_install <conda-env-name> cpu Example log of a a successful building and installing process is like this: P717846260 - Run tests: `run_fbgemm_gpu_tests mycondaenv cpu` under `fbgemm_gpu/tests` directory Reviewed By: q10 Differential Revision: D45139063 Pulled By: excelle08 fbshipit-source-id: fe841aa6321881c7e7d76da8400f3d6eb0354b2e
excelle08
force-pushed
the
export-D45139063
branch
from
6438361 to
cb09c9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45139063 |
|
@excelle08 merged this pull request in 323afc5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
FindAVX.cmakefrom the PyTorch project to detect AVX compilation flags and conditionally add them to FBGEMM_GPU targetsTest Plan:
On a devarm machine:
.github/scripts/setup_env.bashin the FBGEMM repo and run the functions in it.# Assuming the CWD is the FBGEMM repo directory and setup_env.bash is sourced
cd fbgemm_gpu
build_fbgemm_gpu_install cpu
Example log of a a successful building and installing process is like this: P717846260
run_fbgemm_gpu_tests mycondaenv cpuunderfbgemm_gpu/testsdirectoryDifferential Revision: D45139063
Pulled By: excelle08