Fix OSS macos CI error on the trunk #1836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D46832373 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 19, 2023
Summary: Pull Request resolved: pytorch#1836 Fix some trunk issues on OSS FBGEMM macos tests: https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400 ``` /Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter] bool is_bf16_out) { ^ 1 error generated. ``` It should come from D46789900. cc excelle08 sryap Differential Revision: D46832373 fbshipit-source-id: dd8c178c87a77f4eeeb64d27abe02a2978633972
jianyuh
force-pushed
the
export-D46832373
branch
from
a923bf6 to
983588d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46832373 |
jianyuh
added a commit
to jianyuh/FBGEMM
that referenced
this pull request
Jun 19, 2023
Summary: Pull Request resolved: pytorch#1836 Fix some trunk issues on OSS FBGEMM macos tests: https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400 ``` /Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter] bool is_bf16_out) { ^ 1 error generated. ``` It should come from D46789900. cc excelle08 sryap Differential Revision: D46832373 fbshipit-source-id: fd4d54d26bfbd79ead014aeafed2def54286c721
jianyuh
force-pushed
the
export-D46832373
branch
from
983588d to
6906328
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46832373 |
Summary: Pull Request resolved: pytorch#1836 Fix some trunk issues on OSS FBGEMM macos tests: https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400 ``` /Users/runner/work/FBGEMM/FBGEMM/src/RefImplementations.cc:1421:10: error: unused parameter 'is_bf16_out' [-Werror,-Wunused-parameter] bool is_bf16_out) { ^ 1 error generated. ``` It should come from D46789900. cc excelle08 sryap Reviewed By: jspark1105 Differential Revision: D46832373 fbshipit-source-id: f560867711f8979dc69a3057ae70d1d96aad763d
jianyuh
force-pushed
the
export-D46832373
branch
from
6906328 to
c1d7a7a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46832373 |
|
This pull request has been merged in 22eebba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix some trunk issues on OSS FBGEMM macos tests:
https://github.com/pytorch/FBGEMM/actions/runs/5306099684/jobs/9604231400
It should come from D46789900. cc excelle08 sryap
Differential Revision: D46832373