Use TensorList in group_index_select_dim0 #1884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 7747896396e9acf3021bdabb9a054b6feb6c9038
spcyppt
force-pushed
the
export-D47488358
branch
from
3ec7144 to
ad5c45c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: abf753560e462f19c7eebcb4ae7d7b47dcf700a2
spcyppt
force-pushed
the
export-D47488358
branch
from
ad5c45c to
21686e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 898f1d1a4ceb7183fc0ea00d78aa2983b10d0392
spcyppt
force-pushed
the
export-D47488358
branch
from
21686e8 to
5996c3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
spcyppt
added a commit
to spcyppt/FBGEMM
that referenced
this pull request
Jul 20, 2023
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 73e0b7e86c1981d9e73e87fc012c2f3b6c35efa8
spcyppt
force-pushed
the
export-D47488358
branch
from
5996c3e to
acbc878
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
Summary: Pull Request resolved: pytorch#1884 Replace variadic template in `group_index_select_dim0` by packing all tensors into `TensorList` and passing the `TensorList` to autograd function. Return output needs to be tensors of the same size as input specified in the forward functions and can be returned as type of variable_list. This improves performance and lifts limitations of using variadic template that needs to be instantiated for each group size and limits max group size of 55. Reviewed By: sryap Differential Revision: D47488358 fbshipit-source-id: 574b6d4418069fb9e6b17d28484cf8796185a63b
spcyppt
force-pushed
the
export-D47488358
branch
from
acbc878 to
b2f81ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47488358 |
|
This pull request has been merged in 8372bc7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Replace variadic template in
group_index_select_dim0by packing alltensors into
TensorListand passing theTensorListto autogradfunction. Return output needs to be tensors of the same size as
input specified in the forward functions and can be returned as
type of variable_list. This improves performance and lifts
limitations of using variadic template that needs to be instantiated
for each group size and limits max group size of 55.
Reviewed By: sryap
Differential Revision: D47488358