Use Nova workflow to host all published wheel files at PyTorch site #1958

spcyppt · 2023-08-19T00:18:55Z

Summary:
To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead.

#1947

Differential Revision: D48487102

netlify · 2023-08-19T00:19:01Z

✅ Deploy Preview for pytorch-fbgemm-docs canceled.

Name	Link
🔨 Latest commit	`44f7c23`
🔍 Latest deploy log	https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/65023f3d1ef95f00080ae4d7

facebook-github-bot · 2023-08-19T00:19:34Z

This pull request was exported from Phabricator. Differential Revision: D48487102

facebook-github-bot · 2023-08-19T00:37:32Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 2c09e5063307207c45cefe96c1fe5d8f33a51bc1

facebook-github-bot · 2023-08-19T01:01:28Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 3baeedad2fd554b63267eaf6ea6023a01f787de5

osalpekar

Generally looks good! Left a few nits, and might have to iterate a bit to get the builds passing in CI

osalpekar · 2023-08-19T01:12:28Z

.github/workflows/build-wheels-linux.yml

+      pre-script: .github/script/nova_prescript.bash
+      post-script: .github/script/nova_prescript.bash


Should be .github/scripts instead of .github/script. This looks like the cause of the current breakage.

Thank you for catching that! I have fixed it.

osalpekar · 2023-08-19T01:12:55Z

.github/workflows/build-wheels-linux.yml

+      ref: ""
+      pre-script: .github/script/nova_prescript.bash
+      post-script: .github/script/nova_prescript.bash
+      smoke-test-script:


Let's explicitly make the value passed to this arg be ""

Thank you, done.

osalpekar · 2023-08-19T01:18:52Z

.github/scripts/nova_prescript.bash

+#Install CUDA
+$PRELUDE; install_cuda $BUILD_ENV "$CU_VERSION"
+# Install PyTorch Nightly
+$PRELUDE; install_pytorch_pip $BUILD_ENV nightly cuda "$CU_VERSION"


CUDA and the right pytorch version should already be installed for you under the hood by our pipeline, there is no need to do so in your pre-script.

Thank you so much, I've removed them.

facebook-github-bot · 2023-08-19T02:14:30Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 6464b7832f50502c2b4925cea5b5cb62b3880611

atalman · 2023-08-21T17:48:45Z

HI @spcyppt please fix this failure: https://github.com/pytorch/FBGEMM/actions/runs/5908914110/job/16028907266?pr=1958

facebook-github-bot · 2023-08-21T18:19:43Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 2a468a86c430399be26f13de114e45c5062b7526

facebook-github-bot · 2023-08-21T18:26:52Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 185f3963e6b8ea4b7daa82f50bb055b8da6bf5b9

facebook-github-bot · 2023-08-21T19:04:32Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 06704724ad1e4f3be8a24146912823195c33998d

facebook-github-bot · 2023-08-21T20:42:31Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: ce52bd616e60baf1a2e3077f02b57073538b6b6b

facebook-github-bot · 2023-08-21T21:15:31Z

This pull request was exported from Phabricator. Differential Revision: D48487102

…ytorch#1958) Summary: Pull Request resolved: pytorch#1958 To alleviate CUDA version mismatch issues, we publish fbgemm-gpu-nightly with different CUDA versions. This diff uses Nova workflow host the published wheel files at PyTorch site instead. pytorch#1947 Differential Revision: D48487102 fbshipit-source-id: 78af627fe2bafc777d4abc52172ea83e46b192a4

…into export-D48487102

…D48487102

…into export-D48487102

facebook-github-bot · 2025-01-27T01:12:38Z

Hi @spcyppt!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot added the cla signed label Aug 19, 2023

facebook-github-bot added the fb-exported label Aug 19, 2023

spcyppt force-pushed the export-D48487102 branch from f573c22 to a700dae Compare August 19, 2023 00:37

spcyppt force-pushed the export-D48487102 branch from a700dae to 076278f Compare August 19, 2023 01:01

osalpekar reviewed Aug 19, 2023

View reviewed changes

spcyppt force-pushed the export-D48487102 branch from 076278f to cd0f731 Compare August 19, 2023 02:14

spcyppt force-pushed the export-D48487102 branch from cd0f731 to 0a48dec Compare August 21, 2023 18:19

spcyppt force-pushed the export-D48487102 branch from 0a48dec to 8425266 Compare August 21, 2023 18:26

spcyppt force-pushed the export-D48487102 branch from 8425266 to 06138c3 Compare August 21, 2023 19:04

spcyppt force-pushed the export-D48487102 branch from 06138c3 to 2207160 Compare August 21, 2023 20:42

spcyppt force-pushed the export-D48487102 branch from 2207160 to 3c27900 Compare August 21, 2023 21:15

spcyppt added 29 commits September 11, 2023 18:49

[DEBUG] force conda run to print output

2d6330d

[FBGEMM] Fix Nova

c425281

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

83e7f55

…into export-D48487102

Merge branch 'main' of https://github.com/spcyppt/FBGEMM into export-…

9f04f25

…D48487102

[FBGEMM] Fix per rebase

a5803f1

[FBGEMM] Fix nova

def7f5e

[FBGEMM] Fix nova

c031e97

[FBGEMM] Fix nova

c66cbe7

[FBGEMM] Fix nova

8bbe835

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

f1fc5d2

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

871ddfd

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

fb46043

…into export-D48487102

[FBGEMM] Fix Nova

d263265

[FBGEMM] Fix Nova

f1c32ed

[FBGEMM] Fix Nova

80ff28c

[FBGEMM] Fix Nova

f117de8

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

2de8a8f

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

e295d66

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

2a5c670

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

d82e281

…into export-D48487102

Merge branch 'export-D48487102' of https://github.com/spcyppt/FBGEMM …

4e24c8b

…into export-D48487102

[FBGEMM] Fix Nova

87769c4

[FBGEMM][PR] Fix Nova cpu

ccd7c52

[FBGEMM][PR] Add comments, remove print to file

2cb67a0

[FBGEMM] Change -j = nproc/2

810134c

Merge branch 'main' of https://github.com/spcyppt/FBGEMM

680215d

[FBGEMM] Change number of cores to use

7b09c2e

[FBGEMM] Change number of cores to use

892097c

[FBGEMM] Fix init

44f7c23

		pre-script: .github/script/nova_prescript.bash
		post-script: .github/script/nova_prescript.bash

Use Nova workflow to host all published wheel files at PyTorch site #1958

Are you sure you want to change the base?

Use Nova workflow to host all published wheel files at PyTorch site #1958

Uh oh!

Conversation

spcyppt commented Aug 19, 2023

Uh oh!

netlify bot commented Aug 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for pytorch-fbgemm-docs canceled.

Uh oh!

facebook-github-bot commented Aug 19, 2023

Uh oh!

facebook-github-bot commented Aug 19, 2023

Uh oh!

facebook-github-bot commented Aug 19, 2023

Uh oh!

osalpekar left a comment

Choose a reason for hiding this comment

Uh oh!

osalpekar Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

spcyppt Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

osalpekar Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

spcyppt Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

osalpekar Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

spcyppt Aug 19, 2023

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 19, 2023

Uh oh!

atalman commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Aug 21, 2023

Uh oh!

facebook-github-bot commented Jan 27, 2025

Process

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Aug 19, 2023 •

edited

Loading